Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liqoctl: check --dump-values-path install flag #1975

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Liqoctl: check --dump-values-path install flag #1975

merged 1 commit into from
Sep 4, 2023

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Sep 1, 2023

Description

Liqoctl: added a check that raises an error if --dump-values-path is set, while --only-output-values is not.

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 added the kind/bug Something isn't working label Sep 1, 2023
aleoli
aleoli approved these changes Sep 4, 2023
View reviewed changes
cmd/liqoctl/cmd/install.go Show resolved Hide resolved
@fra98 fra98 force-pushed the frt/dump-values-path-fix branch from 7585bc5 to 9b3162a Compare September 4, 2023 10:28
@fra98
Copy link
Member Author

fra98 commented Sep 4, 2023

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frt/dump-values-path-fix branch from 9b3162a to 82d7bb8 Compare September 4, 2023 14:19
@fra98
Copy link
Member Author

fra98 commented Sep 4, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 4, 2023
@adamjensenbot adamjensenbot merged commit 1df7796 into liqotech:master Sep 4, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 4, 2023
@krehel krehel mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fra98 @adamjensenbot @aleoli